I agree with Andrea that the folks who care about these things will necessarily have their editors tuned to their liking. The folks who don’t likely won’t have it enabled or be aware of what’s going on. I’m definitely for pretty code and well configured editors, but personally -1 on including it :)
> On Feb 2, 2017, at 12:52 PM, Andrea Leopardi <[email protected]> wrote: > > While it's a beautiful idea that I have supported for years, editorconfig is > a tricky thing. The biggest drawback IMO is that it requires external editor > integration (via plugin). I believe that if you're someone that cares enough > about this stuff to go and install editorconfig support for your editor, than > you probably already pay attention to stuff like trailing whitespace and > already have your editor setup for that. Of course adding such a config file > to the Elixir repo is not a huge deal, but it's something that we have to > add, see in the file list, keep in the git history, explain what it is to > users, and so on. I think a better approach could be to have a bot that > reviews PRs and just checks for this kind of universal things (trailing > whitespace, encoding), so that it would work even without contributors having > editorconfig support in their editor and would not allow users to > accidentally bypass editorconfig (we would still see the comments in the PR). > But let's see how others feel about this :) > > Andrea > >> On Feb 2, 2017, at 6:44 PM, eksperimental <[email protected]> >> wrote: >> >> Hi everyone, >> I would like to propose to include a .editorconfig file in the Elixir >> project. >> This is the file I have been using during the past year, and I'm very >> pleased with it, as it has >> worked flawlessly so far. >> https://git.io/elixir-editorconfig >> >> For those who never heard of it, Editor Config (http://editorconfig.org/) >> consists of "of a file >> format for defining coding styles and a collection of text editor plugins >> that enable editors to >> read the file format and adhere to defined styles" >> >> It is being used in many big projects: >> https://github.com/editorconfig/editorconfig/wiki/Projects-Using-EditorConfig >> >> It pretty much adheres to the conventions we have in the project, which is: >> - No trailing white-space at the end of lines >> - End file in a new line >> - Use 2 white-spaces instead of tab >> - file charset is UTF-8 >> >> Let me know what you think, >> Additionally I recommend everyone to include it in your project, and send me >> your contributions, >> maybe in the future it could also be included when you create a new project >> running Mix. >> >> Cheers >> >> -- >> You received this message because you are subscribed to the Google Groups >> "elixir-lang-core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/elixir-lang-core/20170203004453.4e20355e.eksperimental%40autistici.org. >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/A5651D8C-5FA7-410A-ACC9-60B55413BC24%40gmail.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/18CB9584-8971-45F0-9954-FA723490E500%40chrismccord.com. For more options, visit https://groups.google.com/d/optout.
