Hey Kelvin, you're welcome to send a PR that adds stricter checks on options :)
Thank you! Andrea Leopardi an.leopa...@gmail.com On Sat, Oct 26, 2019 at 7:24 AM Kelvin Raffael Stinghen < kelvin.sting...@gmail.com> wrote: > Hey! Is this something that is going to be added? I liked the idea of > having that check, and I can send the PR if you don’t mind. > > Best, > Kelvin Stinghen > kelvin.sting...@me.com > > On Oct 16, 2019, at 07:24, José Valim <jose.va...@plataformatec.com.br> > wrote: > > I believe the reporter wants it to raise, since it is not really > supported. If that's the case, please open up a bug report. Thanks. > > > *José Valim* > www.plataformatec.com.br > Skype: jv.ptec > Founder and Director of R&D > > > On Wed, Oct 16, 2019 at 12:05 PM Louis Pilfold <lo...@lpil.uk> wrote: > >> Hello! >> >> What would be the desired behaviour of the `when` option? >> >> Cheers, >> Louis >> >> On Wed, 16 Oct 2019 at 10:51, Thomas Stratmann < >> thomas.stratm...@9elements.com> wrote: >> >>> Hello, >>> >>> a coworker tried `defdelegate fun(..), to: SomeModule, when: >>> some_conditon` the other day. defdelegate does not implement a `when` >>> option, but does not complain about any excess options. >>> >>> Since defdelegate is almost always executed at compile time, the impact >>> of an additional check for the options passed should be negligible. It >>> could raise with a meaningful message. >>> >>> Would this be a welcome change? >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "elixir-lang-core" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to elixir-lang-core+unsubscr...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/elixir-lang-core/8856eeed-f80e-458a-addb-e063e9791473%40googlegroups.com >>> <https://groups.google.com/d/msgid/elixir-lang-core/8856eeed-f80e-458a-addb-e063e9791473%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "elixir-lang-core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to elixir-lang-core+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/elixir-lang-core/CABu8xFAsR95xcnv1ZbwinA3cq_qZJGS8GqARe42u9R%3DJ-Vx4Gg%40mail.gmail.com >> <https://groups.google.com/d/msgid/elixir-lang-core/CABu8xFAsR95xcnv1ZbwinA3cq_qZJGS8GqARe42u9R%3DJ-Vx4Gg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to elixir-lang-core+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4K02nAw%2B5Fg7zkoxoT%3DXmdwHsoqG6H2H%3DR34ZyeFL2-mQ%40mail.gmail.com > <https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4K02nAw%2B5Fg7zkoxoT%3DXmdwHsoqG6H2H%3DR34ZyeFL2-mQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to elixir-lang-core+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/8CC77E59-4856-4CB0-AD2B-BC0C31314BA4%40gmail.com > <https://groups.google.com/d/msgid/elixir-lang-core/8CC77E59-4856-4CB0-AD2B-BC0C31314BA4%40gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAM9Rf%2BKzJejwSHBd_EKwrJCBGosDHr4OSgEjk9a1qFr5z32zKw%40mail.gmail.com.
