2008/12/15 Németh Márton <[email protected]>: > Németh Márton wrote: >> Márton Németh wrote: >>> The argument of VIDIOC_S_INPUT is __u32 according to >>> http://v4l2spec.bytesex.org/spec/r11217.htm . The documentation >>> only says that a pointer to a number should be passed, and this >>> number should be "as in the struct v4l2_input index field". The >>> index field there has __u32 type. >>> >>> This change prevents the following condition to fail: >>> >>> if (*index >= MAX_EM28XX_INPUT) >>> return -EINVAL; >>> >>> Imagine for example if index is signed: index=0x80000000=-2147483648, >>> then the condition above won't return -EINVAL. >> >> The type should be __u32 not only for VIDIOC_S_INPUT, but also >> for VIDIOC_G_INPUT and VIDIOC_ENUMINPUT. > > Sorry, this is the right patch, without modifying the Makefile. >
applied, http://mcentral.de/hg/~mrec/em28xx-new/rev/12f3c396b84b thanks, Markus > > _______________________________________________ > Em28xx mailing list > [email protected] > http://mcentral.de/mailman/listinfo/em28xx > > _______________________________________________ Em28xx mailing list [email protected] http://mcentral.de/mailman/listinfo/em28xx
