>> Actually, looking at the definition of executable-find, I'm surprised it
>> doesn't use locate-file.
> IIRC, executable-find was in existence longe before you added
> locate-file.

Yes, what I meant was that I was surprised I didn't change executable-find
back when I added locate-file (especially since I had added exec-suffixes
not that long before IIRC).

>> The new code is nothing else than a call to locate-file and I'd argue
>> that Eli's change from executable-find to locate-file is a bad idea and
>> instead we should simply move executable-find from executable.el to
>> subr.el.

> Well, if you are going to use integer values as the last arg to
> locate-file (which is deprecated usage, as the doc string says), why
> not call locate-file-internal directly and save a few cycles?

I could but the intention of using an integer arg wasn't to speed things up
but to more closely match the behavior of call-process and start-process.

> Also, I think this should go into files.el, not subr.el, since
> locate-file is in files.el.

Good point.


        Stefan


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Reply via email to