branch: externals/dired-preview
commit caec7a973eb24dd0dabe5b968d29840b562443b2
Author: Protesilaos Stavrou <[email protected]>
Commit: Protesilaos Stavrou <[email protected]>
Add FIXME for the advice and minor mode setup
We discussed this with Christian Tietze and I think the buffer-local
mode is a nice feature to have. I can imagine cases where I want to
explicitly disable the preview in a given Dired buffer.
The discussion with Christian:
<https://lists.sr.ht/~protesilaos/general-issues/%3Cm1zg4noej2.fsf%40christiantietze.de%3E>.
---
dired-preview.el | 3 +++
1 file changed, 3 insertions(+)
diff --git a/dired-preview.el b/dired-preview.el
index 9fd2ec9bd0..000e43f050 100644
--- a/dired-preview.el
+++ b/dired-preview.el
@@ -291,6 +291,9 @@ Use this as advice after relevant Dired commands (see
(add-hook 'post-command-hook #'dired-preview--close-previews-outside-dired
nil :local)
(dired-preview-display-file))
+;; FIXME 2023-06-28: The :global nil and the `advice-add' contradict
+;; each other. I still prefer a buffer-local mode and must thus
+;; arrange for the same job via the `post-command-hook'.
;;;###autoload
(define-minor-mode dired-preview-mode
"Buffer-local mode to preview file at point in Dired."
