branch: externals/dired-preview
commit 00ab2337ca8beccb9cdd9f0582b87d9023c7f910
Author: Protesilaos Stavrou <[email protected]>
Commit: Protesilaos Stavrou <[email protected]>
Stop adding 'no-other-window' parameter
The 'no-other-window' creates problems when the user selects the
window using the mouse, because Emacs disregards that setting. As
such, we have inconsistent behaviour when we try to focus a preview
with the mouse versus the keyboard.
Thanks to Bruno Boal for bringing this matter to my attention:
<https://git.sr.ht/~bboal>. This was done in a private channel and
the information is shared with permission.
---
dired-preview.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dired-preview.el b/dired-preview.el
index b672b8342f..7e6aefb6f1 100644
--- a/dired-preview.el
+++ b/dired-preview.el
@@ -205,8 +205,7 @@ aforementioned user option."
(side . ,(plist-get properties :side))
(slot . -1)
(,(plist-get properties :dimension) . ,(plist-get properties :size))
- (dedicated . t)
- (window-parameters . ((no-other-window . t))))))
+ (dedicated . t))))
(defvar dired-preview-trigger-commands
'(dired-next-line dired-previous-line dired-mark dired-goto-file)