branch: scratch/editorconfig
commit c8031d498343280413bcac7f72be337cf8921237
Author: Stefan Monnier <monn...@iro.umontreal.ca>
Commit: Stefan Monnier <monn...@iro.umontreal.ca>

    WiP: Document test regressions
---
 Makefile                  |  2 +-
 ert-tests/editorconfig.el | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 963f6de2ed..a4e5338c50 100644
--- a/Makefile
+++ b/Makefile
@@ -14,7 +14,7 @@ ERT_TESTS = $(wildcard $(PROJECT_ROOT_DIR)/ert-tests/*.el)
 BATCHFLAGS = -batch -q --no-site-file -L $(PROJECT_ROOT_DIR)
 
 MAIN_SRC = editorconfig.el
-SRCS = $(wildcard $(PROJECT_ROOT_DIR)/*.el)
+SRCS = $(filter-out %-autoloads.el %-pkg.el, $(wildcard 
$(PROJECT_ROOT_DIR)/*.el))
 OBJS = $(SRCS:.el=.elc)
 
 .PHONY: check-unix check-dos \
diff --git a/ert-tests/editorconfig.el b/ert-tests/editorconfig.el
index 92a2dbd4f5..a78a5b0316 100644
--- a/ert-tests/editorconfig.el
+++ b/ert-tests/editorconfig.el
@@ -121,6 +121,14 @@
                 'iso-latin-1-unix)))
   (with-visit-file (concat editorconfig-ert-dir "utf-16be.txt")
     (set-buffer-file-coding-system 'undecided-unix)
+    ;; FIXME: It seems this test uses a non-existing file, and it seems that
+    ;; when using `auto-coding-functions', the coding system is not set in
+    ;; `buffer-file-coding-system' is not set in that case, instead
+    ;; `auto-coding-functions' will be (re)consulted when writing the file.
+    ;; So I think this test needs to be updated.
+    ;; FIXME: Maybe it could also be considered as an Emacs bug that
+    ;; `buffer-file-coding-system' is not set according to `auto-coding-*'
+    ;; when visiting a missing file, but it's not specific to EditorConfig.
     (should (eq buffer-file-coding-system
                 'utf-16be-with-signature-unix)))
   (editorconfig-mode -1))
@@ -128,6 +136,8 @@
 
 (ert-deftest test-local-variables nil
   (editorconfig-mode 1)
+  ;; FIXME: This test fails with the new Emacs-30 hook because we can't
+  ;; really obey `editorconfig-override-file/dir-local-variables' in that case.
   (with-visit-file (concat editorconfig-local-variables-ert-dir 
"file_locals.rb")
     (should (eq tab-width 9))
     (should (eq ruby-indent-level 7)))

Reply via email to