branch: elpa/flycheck
commit 43be6c31100e50df8c7b93b976d7d977bbbb3540
Author: takeokunn <[email protected]>
Commit: takeokunn <[email protected]>
fix(test): skip executable tests for generic checkers
Generic checkers defined with `flycheck-define-generic-checker` have
no `:command` property and no `flycheck-CHECKER-executable` defcustom.
Guard executable-related test assertions with a `command` property
check so they skip in-process checkers like `org-lint`.
---
test/specs/test-checker-api.el | 12 +++++++-----
test/specs/test-customization.el | 15 +++++++++------
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/test/specs/test-checker-api.el b/test/specs/test-checker-api.el
index 8f95a641a6..f7c7225cb7 100644
--- a/test/specs/test-checker-api.el
+++ b/test/specs/test-checker-api.el
@@ -78,14 +78,16 @@
(describe "flycheck-checker-executable"
(it "is-string"
(dolist (checker flycheck-checkers)
- (expect (stringp (flycheck-checker-executable checker))
:to-be-truthy)))
+ (when (flycheck-checker-get checker 'command)
+ (expect (stringp (flycheck-checker-executable checker))
:to-be-truthy))))
(it "override-the-executable"
(dolist (checker flycheck-checkers)
- (let ((variable (flycheck-checker-executable-variable checker)))
- (expect (eval `(let ((,variable "some-nice-executable"))
- (flycheck-checker-executable ',checker)))
- :to-equal "some-nice-executable")))))
+ (when (flycheck-checker-get checker 'command)
+ (let ((variable (flycheck-checker-executable-variable checker)))
+ (expect (eval `(let ((,variable "some-nice-executable"))
+ (flycheck-checker-executable ',checker)))
+ :to-equal "some-nice-executable"))))))
(describe "flycheck-checker-get"
(it "modes"
diff --git a/test/specs/test-customization.el b/test/specs/test-customization.el
index 70f8e9322e..83ffdd4c26 100644
--- a/test/specs/test-customization.el
+++ b/test/specs/test-customization.el
@@ -112,18 +112,21 @@
(it "is a special variable"
(dolist (checker flycheck-checkers)
- (let ((variable (flycheck-checker-executable-variable checker)))
- (expect (custom-variable-p variable) :to-be-truthy))))
+ (when (flycheck-checker-get checker 'command)
+ (let ((variable (flycheck-checker-executable-variable checker)))
+ (expect (custom-variable-p variable) :to-be-truthy)))))
(it "is customizable"
(dolist (checker flycheck-checkers)
- (let ((variable (flycheck-checker-executable-variable checker)))
- (expect (custom-variable-p variable) :to-be-truthy))))
+ (when (flycheck-checker-get checker 'command)
+ (let ((variable (flycheck-checker-executable-variable checker)))
+ (expect (custom-variable-p variable) :to-be-truthy)))))
(it "defaults to nil"
(dolist (checker flycheck-checkers)
- (let ((variable (flycheck-checker-executable-variable checker)))
- (expect (null (symbol-value variable)) :to-be-truthy)))))
+ (when (flycheck-checker-get checker 'command)
+ (let ((variable (flycheck-checker-executable-variable checker)))
+ (expect (null (symbol-value variable)) :to-be-truthy))))))
(describe "flycheck-keymap-prefix"
