branch: externals/org
commit 7b2d3d400bfe823082af048400e59bf365d21c3b
Author: Slawomir Grochowski <[email protected]>
Commit: Slawomir Grochowski <[email protected]>
; org-colview: Simplify summary value collection
* lisp/org-colview.el (org-columns--compute-spec): Bind the collected
values explicitly before calling the summary function.
Refactoring: Extract Function.
No behavior change.
---
lisp/org-colview.el | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index 0fb6b2ce02..f28e04a226 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -1465,12 +1465,10 @@ existing ones in properties drawers."
;; Collect values from lower levels and inline tasks here
;; and summarize them using SUMMARIZE. Store them in text
;; property `org-summaries', in alist whose key is SPEC.
- (let* ((summary
- (and summarize
- (let ((values
- (cl-loop for l from (1+ level) to deepest-level
- append (aref values-by-level l))))
- (and values (funcall summarize values
format-string))))))
+ (let* ((values (and summarize
+ (cl-loop for l from (1+ level) to deepest-level
+ append (aref values-by-level l))))
+ (summary (and values (funcall summarize values
format-string))))
;; Leaf values are not summaries: do not mark them.
(when summary
(org-columns--put-summary pos spec summary)
