branch: externals/org
commit cbb25780eb662319bdd5ec878a0fb9e62716b5a2
Author: Slawomir Grochowski <[email protected]>
Commit: Slawomir Grochowski <[email protected]>
; org-colview: Extract deeper-level value collection
* lisp/org-colview.el (org-columns--values-below-level): New
function.
(org-columns--compute-spec): Use it.
Refactoring: Extract Function.
No behavior change.
---
lisp/org-colview.el | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index 4b11555ddfc..fec35358af5 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -1547,6 +1547,11 @@ they have their own way to be computed."
(vconcat values-by-level
(make-vector (- (1+ level) (length values-by-level)) nil))))
+(defun org-columns--values-below-level (values-by-level level)
+ "Return values in VALUES-BY-LEVEL accumulated deeper than LEVEL."
+ (cl-loop for deeper-level from (1+ level) below (length values-by-level)
+ append (aref values-by-level deeper-level)))
+
(defun org-columns--clear-values-below-level (values-by-level level)
"Clear accumulated values below LEVEL in VALUES-BY-LEVEL."
(cl-loop for deeper-level from (1+ level) below (length values-by-level)
@@ -1588,9 +1593,8 @@ existing ones in properties drawers."
;; and summarize them using SUMMARIZE-FUNCTION. Store them in text
;; property `org-summaries', in alist whose key is SPEC.
(let* ((values (and summarize-function
- (cl-loop for l from (1+ current-level)
- below (length values-by-level)
- append (aref values-by-level l))))
+ (org-columns--values-below-level
+ values-by-level current-level)))
(summary (and values
(funcall summarize-function values
format-string))))
(cond
