Hi Puneeth,
Puneeth Chaganti <[email protected]> writes:
>> However, you need to make sure that it only widens if ID is in the same
>> buffer and outside of the narrow. In particular, when ID is in another
>> file you shouldn’t widen. When it’s within the scope of the narrow it
>> shouldn’t widen. This ALREADY seems to be the case.
>
> I will fix the patch to widen only when the target location is not
> within the narrow. But, I don't understand why we shouldn't be
> widening if the target location is in a different buffer. Can you
> explain?
Reading your latest patch it seems to be correct. I mean, if I click
[[id:myid]] in narrowed buffer A and myid is in buffer B, then you
shouldn’t widen in buffer A. Since you switch buffer there’s no such
issue.
>> However, your patch doesn’t work for me in the following example, starting
>> from emacs -q, adding /tmp/test.org (with the below content) to my agenda
>> list and requiring org-id, org-narrow-to-subtree on foo, and then
>> org-open-at-point on the link
>
> I had patched `org-id-goto' and looks like clicking on links uses
> `org-id-open'. I will resend a patch. I wonder if these two
> functions can reuse common code.
The latest patch from
Date: Sun, 25 Oct 2015 14:36:16 +0530
looks good to me. Thanks!
Rasmus
--
The second rule of Fight Club is: You do not talk about Fight Club
