Kaushal Modi <kaushal.m...@gmail.com> writes: Hi Kaushal,
> Recently the global variable org-log-note-marker was removed from > org.el. > > But it is used in outshine.el as follows: > > (defadvice org-store-log-note (around org-store-log-note-around > activate) > "Outcomment inserted log-note in Outshine buffers." > (let ((outshine-log-note-beg-marker > ;; stay before inserted text > (copy-marker org-log-note-marker nil)) > (outshine-log-note-end-marker > ;; stay after inserted text > (copy-marker org-log-note-marker t))) > ad-do-it > (unless (derived-mode-p 'org-mode 'org-agenda-mode) > (comment-region outshine-log-note-beg-marker > outshine-log-note-end-marker)) > (move-marker outshine-log-note-beg-marker nil) > (move-marker outshine-log-note-end-marker nil))) > > So right now, I am getting this warning at emacs startup: > > ~/.emacs.d/elpa_25_0/outshine-20151203.802/outshine.elc:Warning: > reference to > free variable ‘org-log-note-marker’ > > @ Thorsten, Nicolas: What would be the best way to fix that? > > My org version: > Org-mode version 8.3.2 (release_8.3.2-469-ga902c8 @ > /home/kmodi/usr_local/apps/6/emacs/emacs-25/share/emacs/site-lisp/org/) Thanks for the bug report. Sorry for beeing so late ... but maybe better late than never. I pushed a first fix to origin/trunk. The outcommenting of inserted log-notes in outshine seems to work again, but I encountered a new issue with comment-region: ,---- | ;; * WAITING foo | ;; - State "WAITING" from "TODO" [2016-02-03 Mi 23:46] \\ | ;; waiting for bar `---- It produces this now, which is no good, since outshine expects comments to start at beginning-of-line. I reported this on Emacs Help. Which Org-mode version is the first one with the new org-log-note-marker semantics (to make the advice in outshine conditional on that)? I push this to master once its really fixed. -- cheers, Thorsten
