My think my patch modifies less than 15 lines. Do I have to assign the copyright of FSF? I have sent one. But no response for some days. I hope Org-mode maintainer can merge this patch.
[stardiviner] <Hack this world!> GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Thu, Mar 31, 2016 at 12:52 AM, Thomas S. Dye <t...@tsdye.com> wrote: > Aloha stardiviner, > > For instructions about the FSF papers, see > http://orgmode.org/worg/org-contribute.html. > > All the best, > Tom > > numbch...@gmail.com writes: > > > I updated all comments which you point out. > > I wandering how to sign the FSF papers? Sorry about this, this is my > first time > > to contribute code in open source. > > > > > > > > [stardiviner] <Hack this world!> GPG key ID: 47C32433 > > IRC(freeenode): stardiviner Twitter: @numbchild > > Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 > > Blog: http://stardiviner.github.io/ > > > > On Mon, Mar 28, 2016 at 12:01 PM, Nick Dokos <ndo...@gmail.com> wrote: > > > > stardiviner <numbch...@gmail.com> writes: > > > > > I hope to merge this patch to Org-mode `ob-lisp.el`. > > > > > > > I have only looked at the surface of it, but I see some issues. > > > > > < ;; Copyright (C) 2016-2020 Free Software Foundation, Inc. > > > --- > > > > ;; Copyright (C) 2009-2016 Free Software Foundation, Inc. > > > > Why did you leave out the previous copyright statement? > > Where did 2020 come from? > > > > > < ;; Authors: stardiviner <numbch...@gmail.com> > > > < ;; Maintainer: stardiviner <numbch...@gmail.com> > > > < ;; Keywords: org babel lisp sly slime > > > < ;; URL: https://github.com/stardiviner/ob-lisp > > > < ;; Created: 1th March 2016 > > > < ;; Version: 0.0.1 > > > < ;; Package-Requires: ((org "8")) > > > --- > > >> ;; Authors: Joel Boehland > > >> ;; Eric Schulte > > >> ;; David T. O'Toole <d...@gnu.org> > > >> ;; Keywords: literate programming, reproducible research > > >> ;; Homepage: http://orgmode.org > > > > Why did you erase the previous authors? > > > > Are you volunteering to be the maintainer of ob-lisp.el or are you > > planning to keep your own repo and submit patches? Have you signed > FSF > > papers? > > > > > < ;; Requires SLY (Sylvester the Cat's Common Lisp IDE) and SLIME > > > < ;; See: > > > < ;; - https://github.com/capitaomorte/sly > > > < ;; - http://common-lisp.net/project/slime/ > > > --- > > >> ;; Requires SLIME (Superior Lisp Interaction Mode for Emacs.) > > >> ;; See http://common-lisp.net/project/slime/ > > > > Does it really require both? If so, I suggest you rework it so > > either can be used, but only one is required. If not, I suggest > > you fix the comment. > > > > -- > > Nick > > > -- > Thomas S. Dye > http://www.tsdye.com >
