Hello, Daniel P Gomez <gomez.d...@gmail.com> writes:
> I've amended the commit including the changes you've mentioned. > I did not change the following, though: > > (numberp (string-to-int padlines)) -> (string-match-p "\\`[0-9]+\\'" padlines) > > because that changed the behaviour of org-babel-tangle. Having a > string-match-p as a > match condition broke the default of adding no padlines in the > first tangled SRC block (when passed with no arguments). `string-to-int' will fail the same way as `string-match-p' if `padlines' is nil. So I do not see how the behaviour could differ. Could you elaborate on the issue? > I also noticed that adding this functionality to ob-tangle breaks eldoc > for me. I guess all org babel header arguments have to be strings? I didn't check, but that seems a reasonable assumption. BTW, you didn't include the patch, did you? Regards, -- Nicolas Goaziou 0x80A93738
