-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Nicolas Goaziou <m...@nicolasgoaziou.fr> writes:

> Hello,
>
> I applied the patches with some substantial changes to commit messages
> (often incomplete), removed "subr-x.el" calls (`thread-last' is just
> confusing) and fixed compilation warnings.

Thanks.

About the compilation warnings. I only did "make test". have not do
compilation test. Do you mean compile whole org-mode project or compile
a single file ob-clojure.el with [M-x byte-compile-file]? I will include
this step in my future patch workflow.

>
> Please double-check as I might have fumbled in the process.

After test on my ob-clojure examples. All works fine.

>
> I didn't change "ob-clojure-literate.el" but there are dangling parens
> and whitespace issues to fix. Also, I don't see the need for `dash'
> library, but since it's a contrib/ package, I won't insist of it.
>

I don't know how to replace `-map` and `-contains-p` functions. Is there
any suggestions?

>
> Regards,

BTW, I write some documents on Worg about ob-clojure :ns usage,
ob-clojure-literate.el and ob-js :session usage etc. But I can't push to
remote. Here is my steps.

1. clone.

#+begin_src shell :dir "~/Code/Emacs/"
# git clone https://code.orgmode.org/bzg/worg.git
# or
git clone g...@code.orgmode.org:bzg/worg.git
#+end_src

(I tried both https and git protocols)

- - I have uploaded my SSH key to code.orgmode.org.
- - Tell git to use your private key with worg by updating =~/.ssh/config= with:

   #+begin_src conf
   ## Org-mode SSH key
   Host code.orgmode.org
        HostName code.orgmode.org
        IdentityFile ~/.ssh/id_rsa
   #+end_src

2. Be sure to "pull" the last version of the repository.

   #+begin_src shell :dir "~/Code/Emacs/word/"
   git pull --rebase
   #+end_src   

3. commit

4. push

#+begin_src shell :dir "~/Code/Emacs/worg"
git push
#+end_src

But got error:

,----
|   0 git … remote set-url --add origin https\://code.orgmode.org/bzg/worg.git
|   0 git … remote set-url --delete origin 
\^git\@code\\.orgmode\\.org\:bzg/worg\\.git\$
|   1 git … push -v origin master\:refs/heads/master
| Pushing to https://code.orgmode.org/bzg/worg.git
| Counting objects: 18, done.
| Writing objects: 100% (18/18), 5.87 KiB | 1.17 MiB/s, done.
| Total 18 (delta 13), reused 0 (delta 0)
| POST git-receive-pack (6160 bytes)
| Password for 'https://stardivi...@code.orgmode.org': 
| POST git-receive-pack (6160 bytes)
| error: RPC failed; HTTP 403 curl 22 The requested URL returned error: 403 
Forbidden
| fatal: The remote end hung up unexpectedly
| fatal: The remote end hung up unexpectedly
| Everything up-to-date
`----

I have uploaded my SSH key to code.orgmode.org already.

Magit prompt to ask for password: https://stardivi...@code.orgmode.org
I inputted the password. But still upper error.


- --
[ stardiviner ] don't need to convince with trends.
       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAlrSsL8ACgkQG13xyVro
msMurgf8DnQRN/zorx3/fTVHyMN9iTpYl3iBMMvCCk/L2c+pIfbSf/bh1PuMV+Xk
vkPQQtCCzgzOXxruYd83addjV/C4c/CJ06shkkxoqU9xo+nqJaxkaXD7tjfmZ+Xd
2w8sHNbTRuZfZUbSXe9oF8OOqlzJA7ui9e0TrDAUcSJ2bdAnx4f2kqlCukETe89h
kmGogdDRkRYF/CMIiKtjqvgYgqSmFUboYMSabYQr5w/SWYEDbLmr6S7fDxISmFCt
DjZO4PgU9G/5hxmLU8lRWIWtRf2HRpUtHqp+Djyv+ccgcp1HoDwgEKSlt36XFCx4
orvEkqI0u3n14+/0/AR2gUg9MqcVsA==
=mbVh
-----END PGP SIGNATURE-----

Reply via email to