At 2018-05-03T15:16:17+01:00, Aaron Ecay wrote:

> In principle, you are correct.  However:
>
>> I wonder if something like
>>
>> ------------------------------------------------------------
>> (defun org-babel-do-load-languages (languages)
>
> If we change the arity of the function in this way, usersʼ
> configurations will break.  We could deprecate the old arity-2 calling
> convention, but continue to support it (and give warnings when it is
> used) long enough for users to change their configurations.
>
> Is it worth it though?  Why not just add a docstring to the existing
> function that explains its calling convention and call it a day?

This is a good solution.

>> (defcustom org-babel-load-languages '((emacs-lisp . t))
>>    ...
>>    :set #'(lambda (sym value)
>>             (ignore sym)
>
> You can achieve the same by naming the argument _sym without calling
> ignore.  Underscore-prefixed names are better (in general) than
> ignore, since the byte compiler will warn if you try to access their
> value (whereas, AFAIK, there is no warning if you access an ignore-d
> variable, and thus ignore may be mistakenly misleading.  Since the
> function is so short in this case, the issue doesnʼt really arise).

Thanks for that explanation too, I didn't know that.

Regards,

Raghu.

--
N. Raghavendra <ra...@hri.res.in>, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/

Reply via email to