Bonjour!
Nicolas Goaziou <[email protected]> writes:
> Thank you. It looks good. Feel free to apply it.
Thanks, I did.
> I have two suggestions however:
>
> 1. There is some code duplication, e.g., (dolist ...), could this be
> factored out before applying the patch?
Yes, done, thanks for the hint. The patch has been committed.
> 2. Would it make sense to add the variables to preserve in a dedicated
> top-level variable instead of burying them in the code?
I don't know. Possibly this is a YAGNI. A top-level variable could be
introduced any time. Further someone might come up with a freshly
rewritten agenda in the meantime. ;)
BTW: It might be a good idea to take ideas from `list-buffers' and
friends for the rewrite of the agenda.
Ciao,
Marco
