Nicolas Goaziou <m...@nicolasgoaziou.fr> writes: > Hello, > > Julien Cubizolles <j.cubizol...@free.fr> writes: > >> I'm using org-caldav (https://github.com/dengste/org-caldav/) to >> synchronize the calendar on my Android phone and Org. Recently this >> synchronization stopped working because org-caldav relies on >> org-maybe-keyword-time-regexp that has been dropped from Org. As a >> workaround, could this variable be reintroduced in org so as not to >> break this very useful packageĀ ? > > Could you contact upstream instead? > > AFAICT, they use this variable only twice. The first occurrence doesn't > seem useful (they check for a planning info keyword in a headline, which > cannot happen), it is probably enough to look for `org-ts-regexp-both'. > > I'm not sure about the second one. I guess it would be better for them > to use something like: > > (and (re-search-forward "org-planning-line-re" nil t) > (org-at-planning-p) > (progn > (org-skip-whitespace) > (looking-at org-ts-regexp-both))) > > The (small) issue here is that we cannot properly deprecate a variable > that is not replaced with something else (i.e., we're not using > `define-obsolete-variable-alias' here).
But if we use `make-obsolete-variable', the CURRENT-NAME arg can be a simply explanatory string. I was also recently bit by the removal of a bunch of regexps (in my case, link regexps), and it would have been useful to have some sort of a pointer, either in the obsolescence message or in the docs, about what we're supposed to do instead.