> I'm not sure `org-link-make-description-function' is used a lot out > there, but the change may break existing configurations/hacks.
It should not break anything. I did not remove `org-link-make-description-function' functionality. Just marked it as deprecated. > Also, is it something we could use in the current export backends > or just for the users? If the latter, then I'm in favor of making > this move, probably for 9.5. I am not very familiar with the export code, but the function provided in :description property should follow the same conventions with `org-link-make-description-function'. The only place it is used is org-insert-link. I do not see how it can influence export code. As I understand, org-insert-link is mostly for users. Best, Ihor Bastien <b...@gnu.org> writes: > Hi Ihor, > > Ihor Radchenko <yanta...@gmail.com> writes: > >>> thanks for the patch. I assume you are submitting it against master, >>> am I right? >> >> The patch is against commit 2e96dc639. > > I see, thanks. > >>> From reading this, I don't see what bug it fixes, what problem it >>> solves or what real user need it responds to, but maybe I lost part >>> of the context. Can you explain why this should be applied? >> >> It does not fix any bug. Rather adds a new feature [1]. Currently, org >> provides org-link-make-description-function as user customisation to >> compute default link description. The patch provides a way to set such >> description functions on per link type basis (via :description link >> parameter). Using link parameters looks natural for me since similar >> customisation is already done in :follow and :store link parameters. > > Okay, I understand. It feels natural to me too. > > I'm not sure `org-link-make-description-function' is used a lot out > there, but the change may break existing configurations/hacks. > > Also, is it something we could use in the current export backends > or just for the users? If the latter, then I'm in favor of making > this move, probably for 9.5. > > Nicolas, what do you think? > > -- > Bastien -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China Email: yanta...@gmail.com, ihor_radche...@alumni.sutd.edu.sg