Clemens writes: > My patch aims to get you completion with the default completion and also > for any framework that complies to it out of the box. Without my patch > (and without helm-org) you don't get completion after the first tag I think.
With the built-in completion, org-set-tags-command already supports completing multiple tags. So that aim reduces to using completing-read-multiple because other completion libraries are more likely to play nicely with crm. At the moment that's not mentioned in the commit message (and, less importantly, it wasn't mentioned in the message introducing the patch), but in my view that aim should be the emphasis of the commit message. It'd be good to note the popular completion libraries that don't work out of the box with the current approach, and whether they do after this patch. It's also probably worth mentioning why org-tags-completion-function is still passed as the completion function to completing-read-multiple, as the completion function's main purpose of completing multiple tags could now be fulfilled by completing-read-multiple alone. And what about the other spots that use org-tags-completion-function? Thanks.
