Leo Vivier writes: > Hi there, > > I’m working on the parallelisation of `org-capture' for Org-roam, and > I’ve run into a problem with the updating of `org-capture-plist'. > > ;;--------------------------------------------------------------------- > ;; DESCRIPTION > ;;--------------------------------------------------------------------- > We use the global-variable `org-capture-plist' to populate the > local-variable `org-capture-current-plist' on the init of the > `org-capture' buffer. However, we do not do the opposite (i.e. update > the global-variable with the local-variable) on `org-capture-finalize'. > > This is fine for the majority of `org-capture-finalize', since we’re > using the LOCAL arg of `org-capture-get' to read > `org-capture-current-plist' instead of `org-capture-list', but this > trick does not work for `org-capture-after-finalize', since the hook is > run after the `org-capture-buffer' has been closed. > > This causes problem with `:kill-buffer t', and it limits what can be > done with cleanup functions in `org-capture-after-finalize'. [...]
> ;;--------------------------------------------------------------------- > ;; PATCH > ;;--------------------------------------------------------------------- > I propose to update `org-capture-plist' early in `org-capture-finalize'. > I don’t think this would have unforeseen effects, since > `org-capture-list' is already meant to be transient, and we’d only be > expanding its use from init-only to init-and-exit. Thanks for the detailed write-up and the patch (and sorry for the slow reply). Based on a quick glance, I too think this would be safe to do. > Subject: [PATCH] org-capture: Update plist before finalizing > > * lisp/org-capture.el (org-capture-finalize): Update > `org-capture-plist' with local-value before finalizing. It'd be good to at least point to the motivation/usecase for this change here. (Your description section above already does a nice job of that.) > --- > lisp/org-capture.el | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lisp/org-capture.el b/lisp/org-capture.el > index 2cc1ce394..223ed4124 100644 > --- a/lisp/org-capture.el > +++ b/lisp/org-capture.el > @@ -728,6 +728,9 @@ captured item after finalizing." > > (run-hooks 'org-capture-prepare-finalize-hook) > > + ;; Update `org-capture-plist' with the local-value > + (setq org-capture-plist org-capture-current-plist) Convention nit: please end your comment with a period. Perhaps add a brief mention of `org-capture-after-finalize' (or some other hint of why) here.