Sorry for latency, 9to5 been killing it. Thx for the feedback, make sense! Here is a new patch with the improvements.
>From 680e04217c8e4c536875379cac01edccd694c4cb Mon Sep 17 00:00:00 2001 From: John Herrlin <jherr...@gmail.com> Date: Sun, 10 Jan 2021 21:47:26 +0100 Subject: [PATCH] ob-java: Include static imports in regex * lisp/ob-java.el (org-babel-java--imports-re): Include static imports in Java import regex. TINYCHANGE --- lisp/ob-java.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/ob-java.el b/lisp/ob-java.el index f70a50192..c9698bd72 100644 --- a/lisp/ob-java.el +++ b/lisp/ob-java.el @@ -87,6 +87,7 @@ like javac -verbose." (0+ space) ?\; line-end) "Regexp for the package statement.") (defconst org-babel-java--imports-re (rx line-start (0+ space) "import" + (opt (1+ space) "static") (1+ space) (group (1+ (in alnum ?_ ?.))) ; capture the fully qualified class name (0+ space) ?\; line-end) "Regexp for import statements.") -- 2.30.0
ian martins <ia...@jhu.edu> writes: > John, would you mind if I go ahead and make the change I mentioned and > push it with you as the author? > > On Tue, Jan 12, 2021 at 7:00 AM ian martins <ia...@jhu.edu> wrote: >> >> On Sun, Jan 10, 2021 at 3:55 PM John Herrlin <jherr...@gmail.com> wrote: >> > ian martins <ia...@jhu.edu> writes: >> > > I think the problem was that I was missing static >> > > imports, which you fixed in the first chunk of your patch. I don't >> > > think the rest of the change is necessary. Could you revert the other >> > > chunks and re-test? >> > >> > Thats looks correct! Thanks! >> > >> > Here is a patch with the regexp fix. >> >> That's great. One small change, though. This only allows for a single >> space between "import" and "static" so if someone were to put in two >> it wouldn't work. I actually did the same thing in an earlier version >> and it caused a problem. Since then I went to =(1+ space)= >> everywhere. Could you also move the part that you're adding down to >> the next line. It's not that the line is too long, but it keeps it to >> one thing per line. >> >> The commit message is fine, but the first line shouldn't end in a period. >> >> ref: https://orgmode.org/worg/org-contribute.html#commit-messages
