Hello,
Maxim Nikulin <[email protected]> writes:
> Just a curiosity, what is style guide recommendation: let - lambda or
> cl-labels?
I stay away from CL as much as possible, otherwise newcomers will have
to learn two languages to start contributing, Elisp and CL (cl-loop,
ewww). CL is still necessary however, as we cannot use `seq' yet.
Also, there is `letrec' instead of `cl-labels'.
> In my opinion, a more severe limitation comes from sequential
> regexp-based approach. Consider stripping markers from
> 1. "a =b *c* d= e"
> 2. "*b* /i/"
Fair enough. Here comes another, more involved, attempt.
--8<---------------cut here---------------start------------->8---
(defun org-sort-remove-invisible (s)
"Remove emphasis markers and any invisible property from string S.
Assume S may contain only objects."
;; org-element-interpret-data clears any text property, including
;; invisible part.
(org-element-interpret-data
(let ((tree (org-element-parse-secondary-string
s (org-element-restriction 'paragraph))))
(org-element-map tree '(bold code italic strike-through underline verbatim)
(lambda (o)
(pcase (org-element-type o)
;; Terminal object. Replace it with its value.
((or `code `verbatim)
(let ((new (org-element-property :value o)))
(org-element-insert-before new o)
(org-element-put-property
new :post-blank (org-element-property :post-blank o))))
;; Non-terminal objects. Splice contents.
(_
(let ((contents (org-element-contents o))
(c nil))
(while contents
(setq c (pop contents))
(org-element-insert-before c o))
(org-element-put-property
c :post-blank (org-element-property :post-blank o)))))
(org-element-extract-element o)))
;; Return modified tree.
tree)))
--8<---------------cut here---------------end--------------->8---
It is not perfect, but it does a better job.
WDYT?
> + ;; Space role in sorting.
> + ;; Test would fail for locales with ignored space, e.g. en_US, it works
> + ;; in C and currently rare locales having significant space (es_ES,
> pl_PL)
> + (should
> + (equal "- Time stamp\n- Timer\n"
> + (org-test-with-temp-text "- Timer\n- Time stamp\n"
> + (org-sort-list t ?a)
> + (buffer-string))))))
Since this test is bound to fail for some developers, I assume it
shouldn't be included.
> + (dolist (case '(("Lost =in *verbatim* text= fragment" .
> + "Lost in *verbatim* text fragment")
> + ("Adjucent emphasis: *Overlapped* /regexps/" .
> + "Adjucent emphasis: Ovelapped regexps")))
^^^^
typo
Regards,
--
Nicolas Goaziou
