On 08/08/2021 03:27, Nicolas Goaziou wrote:
Maxim Nikulin writes:
It seems, rx e.g. in emacs-26.3 does not support all features used in
oc.el and oc-csl.el. Loading an org file using git master, I get
a warning
Eager macro-expansion failure: (error "rx form ‘regexp’ requires args satisfying
‘stringp’")
diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el
Thanks. Could you send the patch again with a proper commit message,
using git format-patch?
I going to do it. For a while, I have noticed another problem with a lot
of pcase branches in `org-cite-natbib--style-to-command' in and my
experience is not enough to resolve it. On attempt to byte-compile-file
the following error is reported after significant delay (and CPU fan
becomes more noisy)
oc-natbib.el:108:9:Error: Bytecode overflow
I have tried to comment out some conditions
ls -l lisp/oc-natbib.elc
-rw-rw-r-- 1 ubuntu ubuntu 241882 Aug 8 13:23 lisp/oc-natbib.elc
If more branches are commented out
-rw-rw-r-- 1 ubuntu ubuntu 8525 Aug 8 13:20 lisp/oc-natbib.el
Looks like a kind of combinatorics explosion. It seems, if Emacs-25.2
and 26.3 are considered as supported, this function should be rewritten
to avoid issues with byte compilation.