Hi, No Wayman <iarchivedmywholel...@gmail.com> writes:
> The patch you are viewing is outdated. > This is the latest patch on offer: > > https://list.orgmode.org/87bl4rce4j....@gmail.com/2-0001-Allow-to-delimit-tags.patch Thanks. > It allows "," (the default for completing-read-multiple) and ":" to > delimit tags when completing-read-multiple is used. What does not work if we don't allow ","? > The reason for allowing "," is that it's easier to type than ":". I > make liberal use of tags and IMO typing a "Shift+;" between each tag > is annoying and slow. Okay (but note that we don't all use the same keyboard...) > The comma is also used as the default separator when > completing-read-multiple is used. > >> If we relax a constraint, I'd rather have this hardcoded and well >> documented than adding a new defvar or defcustom. > > The latest patch removed the defcustom and replaced it with a defvar > for the crm-separator regexp. > If it would ease your mind I'd be happy to convert it to a defconst. Instead of a defvar that we don't want the user to modify, why not hardcoding the addition of the coma? I'd prefer this. > It's also worth noting that the constraint was only recently > introduced. > "," worked fine to delimit tags in `org-set-tags-command' prior to the > switch to completing-read-multiple. Okay, this buys it - if I understand what really does not work when allowing ":". > Regarding documentation, let me know where you'd prefer it > documented. Any place in the manual that refers to tag separators, explicitely or implicitely, I've not checked if there are some. Also in the code itself, as a comment, to explain why both "," and ":" should be allowed (avoid the keyboard-based argument, which is too subjective.) Thanks! -- Bastien