On 31/12/2021 02:01, Felipe Lema wrote:
On Thursday, 30 December 2021 22:50:20 +07 Max Nikulin wrote:
I would consider testing if `geiser-eval-region/wait' is bound and fallback to
`geiser-eval-region' otherwise.
I've wrapped an `if` to fallback to previous API before this breaking change in
attached patch.
Felipe, thanks for the patch. It is tracked on https://updates.orgmode.org
Sometimes maintainers merge patches in large batches before a release,
so it may takes months.
--- a/lisp/org/ob-scheme.el
+++ b/lisp/org/ob-scheme.el
Almost certainly it should be "lisp/ob-scheme.el" without "org" in the
middle. It is better to prepare patches using "git format-patch" since
it allows to quickly create a commit with proper message and author
using "git am" command. See https://orgmode.org/worg/org-contribute.html
for details.
+ ;; use `geiser-eval-region/wait' only when available
+ ;; in newer versions of `geiser'
Maybe specifying the version where new feature has been introduced would
be helpful to maintainers to decide at which moment fallback code path
can be removed.
I have not tested if geiser works, but a comment to
https://gitlab.com/emacs-geiser/geiser/-/issues/30 confirms it.
It seems maintainers should check and update your status in respect to
FSF papers on https://orgmode.org/worg/contributors.html since earlier
you wrote that the procedure had been completed.
