Ignacio Casso <ignacioca...@hotmail.com> writes: >> LGTM! Unless others have objections, I am inclined to merge the patch >> fully. But please add changlog entries to the commit message. > > Done. I attach the patch with the new commit message.
Thanks! Some more comments. > Subject: [PATCH] use `set-default-toplevel-value' in `defcustom' setters ^Use > * lisp/ob-lilypond.el (org-babel-lilypond-commands): use ^Use > `set-default-toplevel-value' instead of `set' or `set-default' in > `defcustom' :set argument. > * lisp/ob-shell.el (org-babel-shell-names): Ditto. Please don't use ditto. (what does it even mean?) > This commit fixes a bug that occurred when using an autoload function > inside a let-binding for a custom variable when the feature defining > both the function and the custom variable had not been loaded yet. It would be helpful to reference the relevant ML discussions. Best, Ihor