Hugo Heagren <h...@heagren.com> writes: >> Currently, the internal implementation will treat nil return value as if >> there was no :default-description and org-link-make-description-function >> were set to nil. We may probably document this. It sounds like a useful >> behavior. > > I added some relevant documentation to the `:default-description' part > of the `org-link-parameters' docstring. I also changed the > previosly-failing test to expect the right value. All the tests pass > now.
Thanks! Can you also update the documentation for org-link-make-description-function? > From cd5268bc05324140a4cf384ce12b99bba1ddab47 Mon Sep 17 00:00:00 2001 > From: Hugo Heagren <h...@heagren.com> > Date: Mon, 28 Mar 2022 23:18:45 +0100 > Subject: [PATCH] ol.el: add description format parameter to > org-link-parameters Also, can you please review the comments from Max: https://list.orgmode.org/877d4flu3x....@heagren.com/T/#m3b48d0076a25eaf24b1af48df317984dd4e33fb0 > + ;; Copy all keys in `parameters' and their original values to > + ;; `orig-parameters'. > + (cl-loop for param in parameters by 'cddr > + do (setq orig-parameters > + (plist-put orig-parameters param > (org-link-get-parameter type param)))) Thinking about this part a bit more, I have realized that even better option would be using map-do. Best, Ihor
