Ihor Radchenko <[email protected]> writes: >> As explained in the ChangeLog entry, this points to a more general issue >> where >> `org-cite-basic--get-field' is expected to return nil or a string, but calls >> `org-cite-basic--get-entry' that may return an association list. I am not >> sure >> how to fix that since it means converting anything that >> `org-cite-basic--get-entry' may return into a string. > > Non-string can only be for JSON bibliographies for fields that are not > supported. `org-cite-basic--get-field' can probably return nil in such > scenarios.
I am attaching tentative patch that will make `org-cite-basic--get-field' throw an error when the filed value is not a string. I would appreciate testing. Best, Ihor
>From 9fe6284fdc7ceeb0e0aa8e5a58b6828ca415b6b2 Mon Sep 17 00:00:00 2001 Message-Id: <9fe6284fdc7ceeb0e0aa8e5a58b6828ca415b6b2.1672323564.git.yanta...@posteo.net> From: Ihor Radchenko <[email protected]> Date: Thu, 29 Dec 2022 17:18:35 +0300 Subject: [PATCH] org-cite-basic--get-field: Throw an error on non-nil field values * lisp/oc-basic.el (org-cite-basic--get-field): Throw an error when the field value is not a string. Document the new behavior. Link: https://orgmode.org/list/87edsnsocj.fsf@localhost --- lisp/oc-basic.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el index 01e314bfd..8e69db03c 100644 --- a/lisp/oc-basic.el +++ b/lisp/oc-basic.el @@ -332,7 +332,9 @@ (defun org-cite-basic--get-field (field entry-or-key &optional info raw) Return value may be nil or a string. If current export back-end is derived from `latex', return a raw string instead, unless optional argument RAW is -non-nil." +non-nil. + +Throw an error if the field value is non-string and non-nil." (let ((value (cdr (assq field @@ -343,6 +345,8 @@ (defun org-cite-basic--get-field (field entry-or-key &optional info raw) entry-or-key) (_ (error "Wrong value for ENTRY-OR-KEY: %S" entry-or-key))))))) + (unless (and value (stringp value)) + (error "Non-string bibliography field value: %S" value)) (if (and value (not raw) (org-export-derived-backend-p (plist-get info :back-end) 'latex)) -- 2.38.1
-- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
