Nathaniel Nicandro <nathanielnican...@gmail.com> writes: > I would like to submit a patch that adds support for logind to > `org-user-idle-seconds`. This patch has been working for me for a long > while now and I thought it time for me to submit it. I've contributed > to Emacs in the past so my paperwork should be on file.
Thanks! Though I do not see any commits associated with Nathaniel Nicandro or your email in Emacs git repo. Bastien, may you check FSF records? > Let me know if any changes should be made. > > lisp/org-clock.el | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) Please provide the commit message. See https://orgmode.org/worg/org-contribute.html#commit-messages > +(defvar org-logind-dbus-session-path > + (when (and (boundp 'dbus-runtime-version) > + (require 'dbus nil t) > + (member "org.freedesktop.login1" (dbus-list-activatable-names))) > + (dbus-call-method > + :system "org.freedesktop.login1" > + "/org/freedesktop/login1" > + "org.freedesktop.login1.Manager" > + "GetSessionByPID" (emacs-pid)))) Please provide a docstring for the new variable. Also, this new feature is worth documenting in ORG-NEWS. Otherwise, the patch looks good. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
