Tom Gillespie <tgb...@gmail.com> writes: > Subject: [PATCH] ob-tangle.el: restore :tangle closure evaluation before eval > info > This patch fixes a bug where header arguments like :tangle (or "no") > were treated as if they were tangling to a file named "(or \"no\")". > As a result, org-bable would call org-babel-get-src-block-info with > 'no-eval set to nil, causing parameters to be evaluated despite the > fact that when :tangle no or equivalent is set, the other parameters > should never be evaluated.
What do you mean by "restore"? Were it evaluated in the past? May you please provide a reproducer? > -(defun org-babel-tangle--unbracketed-link (params) > +(defun org-babel-tangle--unbracketed-link (params &optional info-was-evaled) This is not acceptable. Taking care about evaluating INFO should be done in a single place instead of adding checks across the babel code. If we go the proposed way, I expect a number of bugs appearing when somebody forgets to change the eval check in some place. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
