[புதன் அக்டோபர் 11, 2023] Liu Hui wrote: > Hi, > > Thanks for your work. I have two minor suggestions about the patch. > >> + (`file-link >> + (let ((filename (dnd-get-local-file-name url))) >> + (insert (org-link-make-string (concat "file:" filename)))))))) > > I think it is better to abbreviate the file name for file-link, so it > would be consistent with org-insert-link.
OK, will do. >> + (caddr (read-multiple-choice >> + "What to do with dropped file?" >> + '((?a "attach" attach) >> + (?o "open" open) >> + (?f "insert file: link" file-link)))) > > The dialog box is shown in the center of frame and I find it a little > inconvenient compared with a menu popped up just at the mouse > location. How about using x-popup-menu? But isn't that for menus? I don't know how convenient is a menu compared to a dialog box. But if the consensus is that a menu should be popped, then I will adjust the query to use rmc or menu as per use-dialog-box.
