Sławomir Grochowski <slawomir.grochow...@gmail.com> writes: > Philip Kaludercic <phil...@posteo.net> writes: >> I have pushed the changes to master. > > Thank you Philip for your help. It works. > > But there is one more small thing. > A message that is displayed in the minibuffer. > It contains two pieces of information: > > (1) command name > Right now it's hardcoded. > We need to change the it from `help-quick-toggle' to > `org-columns-help-quick-toggle'. > How to do it? > Add another variable like `help-quick-use-map'? > Maybe 'help-quick-command-name'?
Instead of using substitute-command-keys, we could just use this-command, but that assumes that help-quick can always be toggled by the command that invokes it. > (2) keybinding to the command name > Just to modify message string. Add '\\<help-quick-use-map>'. > To use other keymap. > Change is in the diff below. I don't see how this would work in general, at the very least it breaks the regular usage. Furthermore, I am not convinced we have to change anything here, since C-h C-q (the default binding for `help-quick-toggle') should also hide the buffer if one uses your command, or am I mistaken? > > diff --git a/lisp/help.el b/lisp/help.el > index d4e39f04e53..35412b9d2fe 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -263,7 +263,9 @@ help-quick > ;; ... and shrink it immediately. > (fit-window-to-buffer)) > (message > - (substitute-command-keys "Toggle display of quick-help buffer using > \\[help-quick-toggle].")))) > + (substitute-command-keys "Toggle display of quick-help buffer > using\\<help-quick-use-map> \\[org-columns-help-quick-toggle].")))) > + > + > > (defun help-quick-toggle () > "Toggle display of a window showing popular commands and their bindings. > -- > > 2.30.2 > > > Regards, -- Philip Kaludercic on peregrine