Max Nikulin <maniku...@gmail.com> writes: >> Applied, onto main. > > I was expecting that you would be against it since it is a breaking change. > > See a follow-up to > Ihor Radchenko. Re: Autoloading side effects > (was: Re: [BUG] org-mouse is activated without explicit require) > Mon, 12 Dec 2022 10:25:16 +0000 > <https://list.orgmode.org/871qp4j4vn.fsf@localhost>
Not against. The side effects in org-ctags are _disruptive_. And Bastien agreed that we can go ahead with breaking change in this case. Later in the thread we deviated to discussing what exactly constitutes a harmful side effect and what is acceptable, but that's a more general discussion. org-ctags is clearly too aggressive. > However now I am in doubts why org-ctags is not a minor mode. What would be the benefit? > ** Miscellaneous > +*** ~feature-enable~ functions are called for extensions from ~org-modules~ > + > +Accordingly to Emacs [[info:elisp#Coding Conventions][coding conventions]] > +loading a library must not modify behavior > +since it may be done for the sake of help or command completion. > +To make user configuration more convenient, when an extension ~EXT~ listed > +in ~org-modules~ implements ~EXT-enable~ function, it is executed > +during loading of Org mode or in response to customization of ~org-modules~. > +So instead of ~(require 'EXT)~ in your init file add ~EXT~ to ~org-modules~. > +See also > +[[*~org-ctags~ is not activated by default any more][~org-ctags~ is not > activated by default any more]]. I'd like to discuss this idea with enable-feature on emacs-devel first. Maybe we can adapt it more widely without special handling for org-modules. See https://yhetil.org/emacs-devel/87zft9esva.fsf@localhost/ [FR] Provide a way to activate packages automatically for side effect -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
