Matt Huszagh <huszaghm...@gmail.com> writes:

>> Thanks for continuing with this. Moving forward, I think it would be best to:
>> ⁃ Make a patch just for prioritising `#+attr_org'
>> ⁃ Make a patch just improving the regex (before or after the `#+attr_org' 
>> patch)
> ...
>> Lastly, a comment on your documentation patch from earlier. I like the 
>> changes
>> to `org-image-actual-width', however I think you’ve been over-eager with 
>> scrapping
>> the current docstring for `org-display-inline-image--width'. Since the 
>> behaviour
>> is implemented there, I think it should at a minimum be documented there.
>> The docstring for a function referring to a variable’s documentation for how 
>> it’s
>> handled by the function seems a bit weird.

I have used parts of Matt's patches + the new org-element-ast API to
implement all the discussed (and agreed upon) changes:

1. #+attr_org is prioritised
2. Docstrings are updated

Handled, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fede1c990

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to