[செவ்வாய் செப்டம்பர் 17, 2024] Visuwesh wrote:
> Remember to cover the basics, that is, what you expected to happen and > what in fact did happen. You don't know how to make a good report? See > > https://orgmode.org/manual/Feedback.html#Feedback > > Your bug report will be posted to the Org mailing list. > ------------------------------------------------------------------------ > > Hello, > > I have code in my init that calls org-id-find to get the entry ID refers > to. When the ID is non-existent, the function unintentionally changes > the major-mode of the current buffer. > [ This almost caused me to lose a PDF file, but thankfully I could > recover it because of Emacs backup. Admittedly this happened because > I was half-panicking and half-confused. ] > > To reproduce, > > 1. emacs -Q > 2. M-: (require 'org-id) > 3. Visit any file (M-x find-library RET org-id RET) > 4. M-: (org-id-find "non-existent") > 5. Witness the major-mode change > > This all happens in org-id-find-id-in-file where when VISITING is > non-nil, the buffer is (re)used whether or not it was originally in > org-mode. The problem is complicated by the use of find-file-noselect > when MARKERP argument to org-id-find is non-nil. Perhaps, > org-id-find-id-file should check if the current-buffer is derived from > org-mode before returning the buffer-file-name. WDYT? The patch below is what I had in mind. With it, I can no longer reproduce the recipe above. diff --git a/lisp/org-id.el b/lisp/org-id.el index e247fab1d..17568ab31 100644 --- a/lisp/org-id.el +++ b/lisp/org-id.el @@ -705,8 +705,9 @@ (defun org-id-find-id-file (id) (hash-table-p org-id-locations) (gethash id org-id-locations)) ;; Fall back on current buffer - (buffer-file-name (or (buffer-base-buffer (current-buffer)) - (current-buffer))))) + (when (derived-mode-p 'org-mode) + (buffer-file-name (or (buffer-base-buffer (current-buffer)) + (current-buffer)))))) (defun org-id-find-id-in-file (id file &optional markerp) "Return the position of the entry ID in FILE.
