poverobuosodonati <poverobuosodon...@gmail.com> writes: > On the matter: This is not for a reason, and you are of course both > right. Doing something more "advanced" then just hardcoding a fixed > version is definitely a good thing. I was actually also planning to move > over the heuristic I implemented for the tests to the actual module. As > of now, we set the the default framework to the latest available one > that can be discovered on the host system.
Unless I miss something, the new code will err on (require 'ob-csharp) when dotnet command is not available. Also, you left (defvar test-ob-csharp-system-dotnet-version (format "net%s.0" (apply #'max (org-babel-csharp--find-dotnet-version))) in the tests. Why not simply using org-babel-csharp-default-target-framework now? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
