(reattaching this conversation to the list)

Cena Mayo <cenaz...@gmail.com> writes:
> Thank you so much for the feedback, and my apologies for the delay in
> responding.

No worries, we're all doing this on our free time. (For my part, I had
mislaid your email in a rush of other messages and only thought to look
for it today, sorry.)

> Okay - reattached patch. 

Unfortunately, your patch seems to have been diffed against your
previous change, not against the current git head on main, so Git won't
apply it because it cannot find the old links you're updating:

> @@ -49,9 +49,7 @@ divergent implementations.
>  * Requirements and Setup
> 
> Babel support for session-based Scheme evaluation requires 
> [[https://www.nongnu.org/geiser/][Geiser]],
> -which supports 
> [[https://www.nongnu.org/geiser/Installation.html#Installation][several 
> scheme implementations]]
                                                  
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- and so on: there are several URLs in the *deletions* pointing to
the new geiser/Installation.html instead of the old
geiser/geiser_2.html, not just in the *additions*.

I'm not great at git advice, but maybe try making a copy of
ob-doc-scheme.org, doing ~git reset --hard origin/master~ (if it won't
lose you any other work), then replacing ob-doc-scheme.org with the copy
before commiting and doing git format-patch again.

Please hard-wrap those lines (the rest of the document is hard-wrapped
at 70 chars or so).
 
> I also updated the Racket example given later on the page.

Thanks, but did you try executing the src block? I don't use Racket and
haven't got it installed at the moment, but (unless Racket returns the
values of variable definitions?) it looks like it shouldn't return a
result, since it defines the my-hello-world variable, but doesn't
evaluate it. If so, that needs to be fixed, since the following text
tells the reader to expect a result of the code block.

> +(define my-hello-world
> +  (hash-ref translations my-language
> +            "hello world"))
>  #+end_src

The updated example on the Racket page wraps the result in the variable
my-hello-world and pops up a message box:

: (message-box "" my-hello-world)

For our purposes, it's better for the code block to just return a result
to display in the HTML export. Maybe this needs a line evaluating

: my-hello-world

or less confusing in our case, get rid of the variable definition and just
call

: (hash-ref translations my-language "hello world")

as before. Just guessing, so please test with Racket. Absent testing, we
should leave the example as is.

> Please let me know if I need to fix anything - these small corrections
> are a good way to learn how to do this (create a patch, submit,
> contribute to worg) , so happy to hear about any further mistakes. :)

Then perhaps you won't mind going another lap? :)

Yours,
Christian

Reply via email to