Yue Yi <includeyy...@gmail.com> writes: > Yue Yi <includeyy...@gmail.com> writes: > >> > > In other words, when scope is non-nil, we can always obtain an Org >> > > element with a logical hierarchical structure. However, when scope is >> > > nil, we may not be able to do so, as explained in my previous >> > > email. This is why I introduced the scope parameter. >> > >> > Ok. >> > Could you then prepare a full patch, including changelog and maybe add a >> > test? >> >> Sure, I’ll send it over later.
Thanks! I have a few comments about the commit message. > Subject: [PATCH] ox-html: Fix TOC generation for non-toplevel headlines > > When exporting a document that starts with a headline of level > 1 > (e.g., no top-level headline), the HTML table of contents was > rendered incorrectly. This was caused by org-html--toc-text > calculating the initial nesting level based on the first headline's > level, which is incorrect for a global TOC that should always start > from a base level of 0. > > This commit adjusts org-html--toc-text to correctly handle this by > checking its optional scope argument. We generally put changelog entries at the beginning, optionally following by explanation, not wise versa. We also `quote' Elisp symbols and leave two spaces between sentences. See https://orgmode.org/worg/org-contribute.html (I could fix these myself, but considering your interest to become a library maintainer, I want to go through the basic conventions more thoroughly.) -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
