Morgan Smith <morgan.j.sm...@outlook.com> writes: > I apologize for the delay in re-submitting this. I have created a > number of tests to test the current implementation. Then I have > reimplemented `org-clock-sum' using the org-element api (ensuring all > tests still pass). Then I added a new feature that will issue a warning > if the timestamp is not fully specified. > > This brings a big performance improvement.
Thanks! I have a few comments. > From d3d0174bb3bc9be108d50cca0e738db4d9f2598b Mon Sep 17 00:00:00 2001 > From: Morgan Smith <morgan.j.sm...@outlook.com> > Date: Sat, 9 Aug 2025 14:09:20 -0400 > Subject: [PATCH 4/6] Testing: test for malformed clock lines This test is failing unless patch #5 is applied. Something is off. > + (when (and org-clock-report-include-clocking-task > + (eq (org-clocking-buffer) (current-buffer)) > + (eq (marker-position org-clock-hd-marker) > + (org-element-begin > headline-or-inlinetask)) > + (or (not tstart) > + (>= (float-time org-clock-start-time) > tstart)) > + (or (not tend) > + (<= (float-time org-clock-start-time) > tend))) This is not how it worked before. Previously, the clocked task was only included when tstart and tend are both non-nil. Could you please explain this change? > + ;; TODO: can inlinetasks contain inlinetasks? They cannot. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
