Morgan Smith <[email protected]> writes: > I have decided to spend my time fixing compile time warnings in the test > files. If you think that would be a waste of time, I'd have to agree. > > I did find some minor things that might actually be important though. > The first 4 patches are legitimate improvements to the codebase in my > opinion. > > The remaining 11 patches don't really do anything except silence > warnings.
Thanks! Applied, onto main, except PATCH #9 that uses pos-bol/eol that is not yet available in Emacs 28. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=257e5359d https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a2eebc227 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ffccdb629 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=1267b81ec https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=41081a000 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6cd8c6740 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=52a9d968f https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fbf384599 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8f9cdce02 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=98e88a1b5 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=06ffb553e https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a9e6c10fa https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3aee6ad41 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=1afa553ed > Once we do have the number of warnings down to 0, then we might be able > to use the byte compiler to ensure our tests run as expected. Ensuring > that return values are actually used could be a big help. Check out test-duplicates-detector.el. It might be re-used to search for forms without should. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
