Catsup4 <[email protected]> writes: > Sorry if this has been intentionally disabled due to the bug mentioned in the > FIXME comment. I tried tracing back that thread and I couldn't tell if > disabling the string searching was intentional or an unintended side effect
Unintended side effect. Thanks for the fix! > From 825a26e20e1da0904d26f881d9cd445e3974cad1 Mon Sep 17 00:00:00 2001 > From: Catsup4 <[email protected]> > Date: Fri, 7 Nov 2025 20:20:16 -0800 > Subject: [PATCH 1/2] lisp/ol-man.el: restore `::STRING' searching Applied, onto bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eb8c1fff8 > I included this test as a separate commit because it demonstrates the > bug bug behavior and the fix, but perhaps it shouldn't be merged as it > is a brittle test. The testing emacs testing docs mention that you > shouldn't modify customizations, but in this test I set the > `org-man-command' to `man' let-binding is ok, but the test is relying upon the behavior of man command and, more specifically, on how it constructs and searches buffers. > +(ert-deftest test-org-man-open () > + (org-man-open-fixture > + (lambda () > + (let ((org-man-command 'man) You should rather let-bind org-man-command to a helper function that will setup the mock buffer and return it. That will avoid relying on what `man' command does. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
