[email protected] writes: > * lisp/ob-scheme.el (org-babel-execute:scheme): > (org-babel-scheme--get-impl): Extract logic for determining impl as > its own function > (org-babel-scheme-initiate-session): > (org-babel-prep-session:scheme): > (org-babel-load-session:scheme): Added. Implementations similar to > those of other languages (e.g. ob-R) > > These new functions make org-babel-pop-to-session and friends work > correctly.
Thanks for the patch! I think you need to add TINYCHANGE cookie to the commit message as you do not seem to have FSF copyright assignment (correct me if I am wrong) See https://orgmode.org/worg/org-contribute.html > +(defun org-babel-scheme--get-impl (&optional params) > + (or (when (cdr (assq :scheme params)) > + (intern (cdr (assq :scheme params)))) > + geiser-scheme-implementation > + geiser-default-implementation > + (car geiser-active-implementations))) Please, add a docstring. Here, and in all other new functions. > +(defun org-babel-scheme-initiate-session (session params) > ... > + (switch-to-buffer-obey-display-actions t) > + (display-buffer-overriding-action '(display-buffer-no-window > + (allow-no-window t)))) Any specific reason why you set things up differently from `org-babel-scheme-execute-with-geiser': (let ((geiser-repl-window-allow-split nil) (geiser-repl-use-other-window nil)) (let ((repl-buffer (save-current-buffer (org-babel-scheme-get-repl impl repl host port)))) ? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
