Thank you for reviewing my patch and providing valuable feedback!
> 1. Org-mode -> Org mode
You're absolutely correct. I'll update all instances of "Org-mode" to
"Org mode" throughout the documentation for consistency with the
official manual.
> 2. You do not mention that ob-scad can be installed from ELPA. Or is it
> distributed as a part of Openscad itself?
Thank you for pointing this out. The OpenSCAD major mode with Org Babel
support is indeed available via MELPA as the scad-mode package
(https://melpa.org/#/scad-mode). I'll add this installation method to
the "Emacs Configuration" section.
> I am wondering why this was not implemented as a part of ob-scat itself
> when there is :results output. Not relevant to accepting this patch
though.
After examining the `ob-scad.el` source code, I can confirm that the
package is specifically designed for file export functionality only. The
org-babel-execute:scad function requires a `:file` parameter and
contains no logic for capturing console output. The current behavior I
documented reflects the actual implementation. Adding `:results` output
support would indeed be a valuable enhancement for a future contribution.
> I am wondering why you put echo in the example if it is never captured.
You're right, the `echo(version=version())` in the OpenSCAD Title Logo
example serves no purpose since console output isn't captured there. I
included it initially to document the OpenSCAD version used, but it
should only appear in the example where I demonstrate console output
capture. I'll remove it from the logo example.
I'll prepare a revised version of the patch addressing all these points.
Would you like me to resubmit it once the corrections are made?
Thank you again for your thorough review.
--
PS: Resending to the list - originally sent privately by mistake
Regards,
Francois Polito
