Karthik Chikmagalur <[email protected]> writes: >> I feel like all these :errors/:fontsize/whatnot should be documented >> somewhere in a docstring or a comment in the file. They are hard to >> reason about otherwise, unless you are familiar with the code. > > I've added a block comment in org-latex-preview--create-image-async > below the comment that describes the async process tree. It lists all > the info plist keys and their purpose.
> + ;; :processor One of dvipng, dvisvgm or imagemagick What if users add a new processor to `org-latex-preview-process-alist' and select it as default? > + ;; :org-buffer Buffer from which preview is dispatched, not > + ;; necessarily an Org mode buffer. I cannot help but wonder why it is called :org-buffer then. > I've now replaced all instances of this calculation: > > (- (org-element-property :end element) > (or (org-element-property :post-blank element) 0) > (if (eq (char-before (org-element-property :end element)) > ?\n) > 1 0)) > > with this: > > (org-with-wide-buffer > (goto-char (org-element-property :end element)) > (skip-chars-backward "\n\r\t ") > (point)) > > I couldn't find a way to do it with just org-element. If you know of a > better way please let me know. There is none just yet. I will add :pos-before-blank parser property as a part of refactoring branch. This is a common need. >> With this, I went through all the changes, except unrelated to the latex >> preview branch. > > Thanks. I think I've addressed all feedback related to > org-latex-preview.el itself (not ox-html, ox-odt etc) except for > > - %O placeholder in org-latex-preview-process-alist This is yet to be discussed. Pending. > - Redesign of org-latex-preview-live--src-buffer-setup You replied in another email. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
