Morgan Smith <[email protected]> writes: >>> Subject: [PATCH 2/9] test-org/move-subtree: Factor common logic >>> Subject: [PATCH 3/9] test-org/move-subtree: Test for error more precisely >> >> Should these two patches be squashed? >> Otherwise, LGTM. > > The first one is a refactoring that should not meaningfully change > anything. > > The second patch modifies the behavior to test for the error right > where I expect it to be.
Ok. Applied, onto main. Fixed. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=12f68c0d2 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=52b3c6a1a https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fbeb59c5c https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5057f9e2d https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4c575a806 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c0ae29839 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=40f5d0c15 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6ae880e9e https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a96a6762a > Strictly speaking they should be two patches but I don't know if we need > to be strict with the test suite :P. Do you feel I'm clutter up the git > log with too many test suite commits? Just a little. I'd merge the tests and fixes together. But that's not major. My high-level ideas about commits are described in https://orgmode.org/worg/org-contribute.html#orgd3c1761 -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
