Thanks for taking a look! Fixing the HTML line length is trivial. For the ODT styles, I guess if I'm expanding for the numerics I would also need to expand for the full range of alphabetic characters. I can also look at restoring the more useful error messages with `org-priority'.
Cheers, Derek On Fri, Jan 23, 2026 at 4:46 PM Jacob S. Gordon <[email protected]> wrote: > On 2026-01-23 00:38, Derek Chen-Becker wrote: > > Let me take a look at the mouse patch. In the meantime, I worked > > through a bunch (but not all) of the export formatting issues you > > found. > > Awesome, thanks! They generally look good to me (modulo some minor > nits like long lines in ‘org-html--priority’) > > The ODT style file might also need to be updated, since the change > will wrap numeric priorities in styles ‘OrgPriority-#’ but only the > ‘A’, ‘B’, ‘C’ styles are defined in ‘etc/styles/OrgOdtStyles.xml’. > > <style:style style:name="OrgPriority" […]/> <style:style > style:name="OrgPriority-A" […]/> <style:style > style:name="OrgPriority-B" […]/> <style:style > style:name="OrgPriority-C" […]/> > > > So far the only one I'm not 100% happy about is the ox-odt fix, > > because there don't appear to be any unit tests for ox-odt that I > > can add to and I need to think about the best way to test ODT export > > (suggestions, anyone?). > > Yeah the lack of tests isn't great, but it’s a more general problem > that could wait IMO. There isn’t any public ‘plain text’/buffer > export for ODT since it wouldn’t make much sense, but the > ‘content.xml’ inside the ZIP is testable like HTML. Instead of > exporting normally and unzipping (e.g., ‘org-odt--zip-extract’), maybe > a test harness could be built around some export functions (e.g., > ‘org-odt-template’)? If I get a chance I’ll give it a try. > > Last dump of the remaining things I've found (with patches attached), > mostly grepping around with ‘\(priority\|urgen\)\|%[-]*[0-9]*c’. > Squash and rearrange to your heart’s content, Ihor. > > 1. Completion of the ‘PRIORITIES’ file option: go to an Org buffer, > enter ‘#+PRIO’ and hit ‘M-<tab>’ twice. With numeric priorities > you should see, e.g., > > #+PRIORITIES: 1 10 5 > > 2. Speed commands ‘1’, ‘2,’ and ‘3’ were hard-coded to insert ‘?A’, > ‘?B’, and ‘?C’, causing errors for numeric priorities. They now > insert the highest, default, and lowest priorities, respectively. > Some undocumented behaviour of ‘org-priority’ was also changed that > the ‘0’ speed command relied on, which is fixed by passing a symbol > instead. You can try it out with the following buffer and option: > > #+PRIORITIES: 1 10 5 > * Heading > #+begin_src emacs-lisp > (setopt org-use-speed-commands t) > #+end_src > > I also noticed that the error messages have degraded a bit for > ‘org-priority’ (‘Invalid action’ vs. ‘Priority must be between ‘N’ > and ‘M’’), but left them as-is. WDYT about restoring the old ones? > > 3. Font-locking of numeric priorities can fail when the user > customizes ‘org-priority-faces’, e.g., > > (setopt org-priority-faces '((1 . "red"))) > > OR with ‘org-agenda-fontify-priorities’ (they're overridden by the > former), e.g., > > (setopt org-agenda-fontify-priorities '((1 . "green"))) > > OR with neither of these set, the lowest (highest) should be set in > bold (italic). The customization type was actually wrong in the > agenda case, and I’ve updated some related doc strings and > customization types to make them easier to use. > > 4. Some documentation improvements in the manual and guide. In > particular, it wasn’t clear to me how the ‘urgency’ acted for > numeric priorities, but could just be me. > > 5. A small correction in a test case. > > 6. It would be nice if ‘org-lint’ checked for out-of-bounds, invalid > or malformed priorities, so I’ve implemented it. > > Phew, that’s all that’s on my radar in Org. There’s some priority > logic that has to change in [‘org-ql'] (and [‘org-super-agenda’] to a > lesser extent) which may need bug reports. I have some quick patches > in my local versions; should we loop in Adam? Are there any other > popular packages that might be affected? > > Besides ‘org-mouse’ I hope that’s it! > > [‘org-ql’]<https://github.com/alphapapa/org-ql> > [‘org-super-agenda’]<https://github.com/alphapapa/org-super-agenda> > > Best, > > -- > Jacob S. Gordon [email protected] Please don’t send me HTML > emails or MS Office/Apple iWork documents. > https://useplaintext.email/#etiquette > https://www.fsf.org/campaigns/opendocument -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
