Tim Hansinger <[email protected]> writes: > Hello Rudy,
Tim, hi! > sorry for the long time it took. Looks like everyone is busy this winter. Me too! :) > I haven't created a patch yet but thought I would just send the code > [...] Main changes to your code are: [...] Great work! Love the use back-references. Smart! > I tested it thoroughly and couldn't find any issues with this code. I would be great to capture (at least) "the spirit" of the change in `test-ob-plantuml.el' so we avoid future regressions. > Would appreciate your feedback but I believe it is quite clean. It looks great. > If you like we could of course move the whole (rx ...) part directly > into the (_ (string-match regex body)) part so we don't define a > variable regex... but other than that I wouldn't change much. Your call. As always, maintainability is the top priority. Rudy -- "It is no paradox to say that in our most theoretical moods we may be nearest to our most practical applications." --- Alfred North Whitehead, 1861-1947 Rudolf Adamkovič <[email protected]> [he/him] http://adamkovic.org
