-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Patch applied, thanks!

Garid Zorigoo <[email protected]> writes:

> * Situation:
> - Context: I have 2 org-contacts-files
> - Bug: [[org-contact:]] link:
>   - only works to the 1st file
>   - cannot open link to 2nd file
>
> * Reproduce with following:
> ** file /tmp/a.org
> #+begin_src org :tangle /tmp/a.org
> ,* Person A-1
> :PROPERTIES:
> :NAME:     A-1
> :EMAIL:     [email protected]
> :END:
>
> ,* Person A-2
> :PROPERTIES:
> :NAME:     A-2
> :EMAIL:     [email protected]
> :END:
> #+end_src
>
> ** file /tmp/b.org
> #+begin_src org :tangle /tmp/b.org
> ,* Person B-1
> :PROPERTIES:
> :NAME:     B-1
> :EMAIL:     [email protected]
> :END:
>
> ,* Person B-2
> :PROPERTIES:
> :NAME:     B-2
> :EMAIL:     [email protected]
> :END:
> #+end_src
>
> ** Setting org-contacts-files
> #+begin_src emacs-lisp
> (setq org-contacts-files '("/tmp/a.org" "/tmp/b.org"))
> #+end_src
>
> ** Openning Links with org-open-at-point
>
> - [[org-contact:Person A-2]] : working
> - [[org-contact:Person B-2]] : NOT working
>
> * Why I think the bug is happening:
> The org-contacts-link-open function only using
> (car (org-contacts-files)), ignores remainger.
>
> #+begin_src emacs-lisp
> (defun org-contacts-link-open (query)
>   "Open org-contacts: link with jumping or searching QUERY."
>   (let* ((file-path (car (org-contacts-files)))         <------ THIS LINE
> ----
>          (file-name (file-name-nondirectory file-path))
>           ...
> #+end_src
>
> * This patch fixes includes:
> - Iterate over each file in 'org-contacts-files' and run the query against
> each one.
> - Replace 'occur' with 'multi-occur' so /query/ format searches are
> performed on all files/buffers.
> [4. text/x-patch; 
> 0002-Fix-org-contacts-link-open-for-multiple-org-contacts.patch]...

- -- 

[ stardiviner ]
I try to make every word tell the meaning that I want to express without 
misunderstanding.

Blog: https://stardiviner.github.io/
IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAmmZcysACgkQG13xyVro
msOksQf/ZPWYb9eT1QclacT0XEsAPxkyABpDjdMLzzrpo+veTJ39E2Wb97iHUVlY
DEEx2bPXYPv5/RirGmn/cJutWOl6NdTSPegPRZkbkq5JXtHgK0qkHKylMETTs0is
3mjQllh1XWd9uQZV84FgdzwxtHaYUptpTM6nixHm2Is139wA5SPu/xHPhNpyAouY
ytZbbeBn266RXOoW6eIGAIR1l1485CCoBUy/bx2ryazdayCPlhbNiGey7L4gVVa+
QDvk7sLCDNaTfDCRrZysr1APazom131ZAJ1obGmCDZKbVQCXHO1G5OTGMUVGh1Vv
yPKqpvIsbzjLNhxHMHE1vKpzVT/p0Q==
=y5oX
-----END PGP SIGNATURE-----

Reply via email to