Thanks, the updated patch looks great! All tests pass. Approved, for Ihor to take a look at.
Cheers, Derek On Thu, Apr 30, 2026 at 3:43 AM Lei Zhe <[email protected]> wrote: > Great comments. Thanks, please check out the new patch. > > Cheers, > > Lei Zhe > > On Wed, Apr 29, 2026 at 8:29 PM Derek Chen-Becker <[email protected]> > wrote: > > > > Thanks for the patch, it generally looks good. A couple of comments: > > > > - Would you mind adding a unit test for the new behavior? I confirmed > that all existing tests pass but it would be good to add a new one > > - For the defcustom description, I'm wondering if it would be better to > phrase it in terms of what the non-default behavior is since that's how you > phrase the change in news. Or maybe just include "(the default)" like you > did in the manual > > > > Cheers, > > > > Derek > > > > On Wed, Apr 29, 2026 at 4:03 AM Lei Zhe <[email protected]> wrote: > >> > >> Sure, please check the new patch. > >> > >> Lei Zhe > >> > >> On Sat, Apr 4, 2026 at 11:23 PM Ihor Radchenko <[email protected]> > wrote: > >> > > >> > Lei Zhe <[email protected]> writes: > >> > > >> > > Sure, please check out the patch. > >> > > >> > LGTM. > >> > > >> > > BTW, do we need to document the change in org-manual.org? > >> > > >> > It is probably a good idea. Although, the manual does not mention > about > >> > tangling in commented/archived trees. So, a whole dedicated paragraph > >> > needs to be added describing these. > >> > > >> > -- > >> > Ihor Radchenko // yantar92, > >> > Org mode maintainer, > >> > Learn more about Org mode at <https://orgmode.org/>. > >> > Support Org development at <https://liberapay.com/org-mode>, > >> > or support my work at <https://liberapay.com/yantar92> > > > > > > > > -- > > +---------------------------------------------------------------+ > > | Derek Chen-Becker | > > | GPG Key available at https://keybase.io/dchenbecker and | > > | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | > > | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | > > +---------------------------------------------------------------+ > > > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
